-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Android double masking with frame drop #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* andrey/nonstandard-views: Attached dialog sample space use Canvas for certain types of windows consolidate in one view sample of adding floating views add floating button test: Add UI and logic to evaluate boolean flags (#305)
…ed-mask2 * andrey/do-not-send-duplicate-windows: Unit tests Volatile address feedback Fix feedback Recycle bitmap early fix size bug no message
* main: feat: Android SR Identify support (#330)
* main: test: O11Y-908 - Add Android CI workflows (#337) chore: release main (#335) feat: publish umd for broser environments (#334) chore: release main (#333) feat: Pause and resume replay capture on app background/foreground (#329) fix: Fix compose coordinate offset. (#331) chore: release main (#324) fix(highlight.run): correct privacy masking for empty strings (#332)
* main: chore: Android SR - cleanup privacy settings (#341)
This reverts commit feaa22f.
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskApplier.kt
Outdated
Show resolved
Hide resolved
* main: chore: update LaunchDarkly SDK dependencies (#336)
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskApplier.kt
Outdated
Show resolved
Hide resolved
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskApplier.kt
Show resolved
Hide resolved
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
agrognetti
approved these changes
Jan 9, 2026
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskApplier.kt
Outdated
Show resolved
Hide resolved
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskApplier.kt
Show resolved
Hide resolved
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskApplier.kt
Show resolved
Hide resolved
Co-authored-by: Agustin Grognetti <[email protected]>
Merged
abelonogov-ld
pushed a commit
that referenced
this pull request
Jan 9, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.23.0</summary> ## [0.23.0](launchdarkly-observability-android-0.22.0...launchdarkly-observability-android-0.23.0) (2026-01-09) ### Features * Android double masking with frame drop ([#342](#342)) ([803fb83](803fb83)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Publishes a new release of the Android SDK with a masking enhancement. > > - **Release:** `sdk/@launchdarkly/observability-android` → `0.23.0` > - **Feature:** *Android double masking with frame drop* > - **Meta:** Update version in `gradle.properties` and `.release-please-manifest.json`; add `CHANGELOG.md` entry > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 89623b0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces double masking and if number of masks changed the frame being dropped.
How did you test this change?
Are there any deployment considerations?
Note
Introduces double-masking to stabilize sensitive-region masking and avoid flicker by dropping unstable frames.
CaptureSource), merge viaMaskApplier.mergeMasksMapwith position tolerance; if counts/IDs shift or movement exceeds threshold, drop the frameMaskApplier.drawMasks; compose layered windows onto base bitmap, recycle intermediate bitmaps, and improve PixelCopy error handling and cleanuppickBaseWindownow returns index; capture proceeds from base through overlays; maintains tiled signature dedupelocalToWindowin Compose masking; minor matrix reuse comment in native target.ldMask()to ZIP and CVV fields; minor cleanup in Compose/XML samplesWritten by Cursor Bugbot for commit 5bff2cd. This will update automatically on new commits. Configure here.